Remove preamble function Module['applyStackValues']() #10042
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uced in emscripten-core#9569. That is same as JS library function establishStackSpaceInJsModule().
juj
force-pushed
the
remove_applyStackValues
branch
from
41799b8 to
20e0a49
Compare
kripken
approved these changes
Dec 16, 2019
belraquib
pushed a commit
to belraquib/emscripten
that referenced
this pull request
Dec 23, 2020
…e#10042) * Remove preamble function Module['applyStackValues']() that was introduced in emscripten-core#9569. That is same as JS library function establishStackSpaceInJsModule(). * Fix establishStackSpace() for wasm backend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove preamble function
Module['applyStackValues']()that was introduced in #9569. That is same as JS library functionestablishStackSpaceInJsModule().This simplifies preamble.js and worker.js a little.