-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Closed
Labels
Description
As a followup to #11319 we have a lot of potential cleanup of emscripten to do now that fastcomp is no more.
One thing to consider: do we want to make backporting/cherrying picking easy(er) for while). Should we hold off large refactors for a while for this reason? It seem like there will be enough pure-deletion PRs to keep us going for while :)
List of cleanup work:
- Remove asmjs validation (Remove asmjs validation #11551).
- Remove JS in
src/inside!WASM_BACKEND - Remove check_vanilla and is_vanilla cache file, @sbc
- Remove all Python driver code inside
not WASM_BACKEND - Remove
WASM_BACKENDcompletely. - Remove fastcomp-only settings in settings.js.
- Remove dual/split cache (cache/asmjs vs cache/wasm)
- Remove fastcomp backend code in emscripten.py.
- Remove
WASM? (even with-s WASM=0we setWASMto 1 and setWASM2JS, inverify_settings. soWASM == 1all the time in tests etc.)
Cleanup PRs should mention "See #11860" (this PR).