[WIP] Deprecate Evented #20970
Draft
[WIP] Deprecate Evented #20970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
|
I just realized that the approach of two mixins may not work with EDIT: A Proxy won't easily work either because we look for whether it's in a EDIT 2: I've reworked this and it should work as expected now. |
wagenet
force-pushed
the
deprecate-evented
branch
from
2319116 to
4a66206
Compare
wagenet
force-pushed
the
deprecate-evented
branch
from
4a66206 to
6a955a2
Compare
Estimated Asset SizesDiff --- main/out.txt 2025-09-04 03:19:38.000000000 +0000
+++ pr/./pr-17484044865/out.txt 2025-09-05 04:53:38.000000000 +0000
@@ -1,46 +1,46 @@
╔═══════╤═══════════╤═══════════╗
║ │ Min │ Gzip ║
╟───────┼───────────┼───────────╢
-║ Total │ 418.65 KB │ 232.22 KB ║
+║ Total │ 415.84 KB │ 230.92 KB ║
╚═══════╧═══════════╧═══════════╝
-╔══════════════════════╤══════════╤═══════════╗
-║ @ember/* │ Min │ Gzip ║
-╟──────────────────────┼──────────┼───────────╢
-║ Total │ 239.4 KB │ 147.23 KB ║
-╟──────────────────────┼──────────┼───────────╢
-║ -internals │ 35.46 KB │ 25.49 KB ║
-║ application │ 12.83 KB │ 7.7 KB ║
-║ array │ 12.66 KB │ 7.32 KB ║
-║ canary-features │ 304 B │ 419 B ║
-║ component │ 1.07 KB │ 1005 B ║
-║ controller │ 1.8 KB │ 1.36 KB ║
-║ debug │ 11.4 KB │ 7.92 KB ║
-║ deprecated-features │ 31 B │ 77 B ║
-║ destroyable │ 561 B │ 383 B ║
-║ enumerable │ 259 B │ 387 B ║
-║ helper │ 823 B │ 605 B ║
-║ instrumentation │ 2.43 KB │ 1.78 KB ║
-║ modifier │ 669 B │ 581 B ║
-║ object │ 33.78 KB │ 20.79 KB ║
-║ owner │ 159 B │ 178 B ║
-║ renderer │ 406 B │ 350 B ║
-║ routing │ 58.08 KB │ 33.43 KB ║
-║ runloop │ 2.2 KB │ 1.33 KB ║
-║ service │ 859 B │ 741 B ║
-║ template │ 430 B │ 364 B ║
-║ template-compilation │ 429 B │ 366 B ║
-║ template-compiler │ 57.91 KB │ 30.4 KB ║
-║ template-factory │ 94 B │ 160 B ║
-║ test │ 923 B │ 627 B ║
-║ utils │ 3.93 KB │ 3.5 KB ║
-║ version │ 55 B │ 131 B ║
-╚══════════════════════╧══════════╧═══════════╝
+╔══════════════════════╤═══════════╤══════════╗
+║ @ember/* │ Min │ Gzip ║
+╟──────────────────────┼───────────┼──────────╢
+║ Total │ 236.59 KB │ 145.9 KB ║
+╟──────────────────────┼───────────┼──────────╢
+║ -internals │ 37.76 KB │ 27.22 KB ║
+║ application │ 12.88 KB │ 7.57 KB ║
+║ array │ 12.68 KB │ 7.33 KB ║
+║ canary-features │ 304 B │ 419 B ║
+║ component │ 1.07 KB │ 1016 B ║
+║ controller │ 1.87 KB │ 1.38 KB ║
+║ debug │ 11.45 KB │ 7.96 KB ║
+║ deprecated-features │ 31 B │ 77 B ║
+║ destroyable │ 561 B │ 383 B ║
+║ enumerable │ 307 B │ 497 B ║
+║ helper │ 823 B │ 581 B ║
+║ instrumentation │ 2.43 KB │ 1.78 KB ║
+║ modifier │ 669 B │ 621 B ║
+║ object │ 27.58 KB │ 17.3 KB ║
+║ owner │ 159 B │ 178 B ║
+║ renderer │ 406 B │ 331 B ║
+║ routing │ 58.85 KB │ 33.71 KB ║
+║ runloop │ 2.2 KB │ 1.34 KB ║
+║ service │ 859 B │ 755 B ║
+║ template │ 430 B │ 393 B ║
+║ template-compilation │ 429 B │ 366 B ║
+║ template-compiler │ 57.91 KB │ 30.4 KB ║
+║ template-factory │ 94 B │ 160 B ║
+║ test │ 923 B │ 627 B ║
+║ utils │ 3.99 KB │ 3.53 KB ║
+║ version │ 55 B │ 131 B ║
+╚══════════════════════╧═══════════╧══════════╝
╔═════════════════╤═══════════╤══════════╗
║ @glimmer/* │ Min │ Gzip ║
╟─────────────────┼───────────┼──────────╢
-║ Total │ 179.25 KB │ 84.99 KB ║
+║ Total │ 179.25 KB │ 85.02 KB ║
╟─────────────────┼───────────┼──────────╢
║ destroyable │ 2.7 KB │ 1.35 KB ║
║ encoder │ 596 B │ 653 B ║
@@ -53,7 +53,7 @@
║ program │ 7.1 KB │ 3.63 KB ║
║ reference │ 5.51 KB │ 3.18 KB ║
║ runtime │ 95.26 KB │ 42.69 KB ║
-║ tracking │ 989 B │ 961 B ║
+║ tracking │ 989 B │ 992 B ║
║ util │ 3.03 KB │ 2.29 KB ║
║ validator │ 15.64 KB │ 6.86 KB ║
║ vm │ 784 B │ 798 B ║Details
|
ef4
reviewed
Sep 5, 2025
There was a problem hiding this comment.
Notes from RFC discussion: this file might have been unintentionally included.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We still need to figure out correct deprecation ids.
ember-learn/deprecation-app#1404