Convert in-depth topics to use gjs #2127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ember-guides ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
tcjr
commented
Jul 29, 2025
tcjr
commented
Jul 29, 2025
tcjr
commented
Jul 29, 2025
tcjr
commented
Jul 29, 2025
|
Some of the built-in imports are documented here: https://guides.emberjs.com/release/components/template-tag-format/#toc_importing-built-ins |
But not 'component' or 'helper' or 'modifier'. |
ya, these are built-in keywords |
Oh, nice. I can just delete those TODO placeholders. |
…elpers as keywords
|
Would be great to also have those documented as built-in keyword on the template tag page! |
- no extensions - no relative paths
tcjr
commented
Aug 5, 2025
kategengler
approved these changes
Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the 4 markdown files in the Core Concepts / In-Depth Topics to use gjs.
I tried to limit the changes here to only migrating from
js+hbstogjs. In a few places, some reordering of the prose around the code snippets was unavoidable. Based on the number of changes, I'd recommend going through the rendered docs and see if anything looks awry.Some notes:
gjsrequires explicit imports, I added imports for things likeInputandmodifier. But I don't know the imports for thecomponenthelper andhelperhelper, so those should be addressed.autotracking-in-depth, some of the snippets now have diff indicators where they didn't before.rendering-values, everything that was justhandlebarshas been wrapped in<template></template>in agjsblock. Many of these care incomplete however, because they reference stuff that is not in scope. I think this is fine, but maybe somebody else has an opinion on a better way to handle these.Leaving as a draft until I figure out the imports.