-
-
Notifications
You must be signed in to change notification settings - Fork 72
package: update ember-styleguide
, ember-showdown-prism
, ember-auto-import
deps
#1279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for ember-deprecations ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
At build time, a warning is logged: ``` Usages of the Ember Global may be caused by an outdated ember-cli-babel dependency. The following steps may help: * Upgrade the following addons to the latest version: * ember-styleguide ``` As such, let's bump to the newest version of this package. See https://github.com/ember-learn/ember-styleguide/releases for the package's release notes. This should help along the way to achieving: #1272.
Removing the The failing linter command was |
Ah, sorry about that! I'll take a look tonight and see if I can get a working change set out for your review. |
Let's update our dependency on `ember-showdown-prism` to v3.2.0. This will ensure that all of our dependencies' dependencies on `@ember/render-modifiers` can be resolved to a single version.
For context, `ember/dependency-lint` is an addon that adds lint tests that verify only one version of any given addon will be activated in the final built application. Right now, we've explicitly overriden that behavior for `ember-concurrency` in the config/dependency-lint.js file to allow either version 2.1.2 or version 1.3.0 to be installed. Given this configuration, if any other version is installed, ember/dependency-lint will throw a linter error. After updating `ember-styleguide` we only depend on v2.3.7 of the ember-concurrency package, so no extra configuration should be required for this package to lint successfully. As such, let's go ahead and remove this setting in the config file.
ember-styleguide
depember-styleguide
, ember-showdown-prism
deps
Hi @jenweber, I think that the linter issues are coming from
Digging into the first issue a bit, the dependency tree looks like:
Interestingly, we do depend on render-modifiers, but don't appear to actually use it from what I can tell, so I submitted #1283 to remove that. For For the second issue, since we and I think that once #1283 has been merged, this should lint successfully (or at least it did when I merged it locally). Please let me know if there's anything else that I can do here! 😄 |
`ember-prism` requires `ember-auto-import` >= v2, and without it, the app will not build successfully. As such, let's update our dependency to be compatible.
ember-styleguide
, ember-showdown-prism
depsember-styleguide
, ember-showdown-prism
, ember-auto-import
deps
I updated this branch with
I think possibly this can be solved by installing webpack. It looks like they are still on v5.
|
Ah, darn! I'm not sure why I'm not seeing that locally... I'll try your suggestion and see if that makes the CI happy. Sorry for the inconvenience here. |
Let's install a dev dependency on v5 of webpack in an attempt to resolve the error: ``` [ember-auto-import] this version of ember-auto-import requires the app to have a dependency on webpack 5 ``` which occurs when running the test script via CI.
Thanks for the suggestion, that seems to have done the trick! Please let me know if there's anything else that we should do here. 😃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks great in the click test, thank you!
At build time, a warning is logged:
As such, let's bump to the newest version of this package. See https://github.com/ember-learn/ember-styleguide/releases for the package's release notes.
This should help along the way to achieving: #1272.