Add instructions for targeting generators to in-app-repo #239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for ember-cli-guides ready! 🔨 Explore the source changes: 2a79f81 🔍 Inspect the deploy log: https://app.netlify.com/sites/ember-cli-guides/deploys/61a8d25d9d12960007af6815 😎 Browse the preview: https://deploy-preview-239--ember-cli-guides.netlify.app |
jenweber
requested changes
Oct 28, 2021
Contributor
jenweber
left a comment
jenweber
left a comment
There was a problem hiding this comment.
Thank you for this improvement! I have a couple suggestions. After applying the one using the full generate command, I think this is good to merge.
Co-authored-by: Jen Weber <[email protected]>
Co-authored-by: Jen Weber <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know that these instructions can be derived/inferred from the "Generating an in-repo-addon blueprint" section but when scanning the headings it took several passes over the content before I made this realization. Thought maybe a specific section highlighting this usage would be beneficial.