Fix version import #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were circular import issues most notably during install. `setup.py` now grabs the version information without having to import the module (which led to importing other modules which isn't appropriate during setup.py activities).
|
+1 |
joncotton
added a commit
that referenced
this pull request
Nov 15, 2013
Fix version import. `__init__.py` is the canonical location
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setup.pynow accesses the version information without importing the module, which caused problems.__init__.pyis the canonical location now, which is better I think.client.pyavoids circular imports by only importing the version when it needs it.Follow up to changes in 563de9d