Fix(eval): Correctly handle scientific notation in expressions #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![google-labs-jules[bot]](https://avatars.githubusercontent.com/in/842251?s=60&v=4){kind=small}
The `evaluate_expr` function was incorrectly calling `convert_scinot` on expressions that could already be converted to a float. This would cause expressions in scientific notation to be processed incorrectly. This change corrects the `evaluate_expr` function to return the expression directly if it can be converted to a float, preventing the incorrect processing. Additionally, a test for scientific notation was updated to use a more descriptive variable name, improving readability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes a bug in the
evaluate_exprfunction that caused incorrect handling of expressions in scientific notation. The function now correctly returns the expression if it can be converted to a float, and a related test has been improved for clarity.