Skip to content
This repository was archived by the owner on Jul 8, 2023. It is now read-only.

Conversation

@garex
Copy link
Contributor

@garex garex commented Sep 19, 2017

See composer issue composer/composer#4520

Fixes issue #5

@codecov
Copy link

codecov bot commented Sep 19, 2017

Codecov Report

Merging #17 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             master    #17   +/-   ##
=======================================
  Coverage       100%   100%           
- Complexity       40     42    +2     
=======================================
  Files             7      7           
  Lines           117    122    +5     
=======================================
+ Hits            117    122    +5
Impacted Files Coverage Δ Complexity Δ
src/NpmBridgeFactory.php 100% <100%> (ø) 5 <2> (+2) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f035cc...62145f3. Read the comment docs.

@ezzatron ezzatron merged commit 62145f3 into eloquent:master Sep 19, 2017
@ezzatron
Copy link
Contributor

Thanks for the PR! This was released in 4.0.1.

FYI I moved the preloading into the plugin class, preloaded more classes that might be used, and added some tests.

@ezzatron ezzatron added this to the 4.0.1 milestone Sep 19, 2017
@garex
Copy link
Contributor Author

garex commented Sep 19, 2017

tnx, I also thought about it, but decided that it's factory's responsibility. Anyway it's working now and we are happy.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants