Update config on receiving remote SDP #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickel8
force-pushed
the
update-config
branch
from
aee5f67 to
65f6b88
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #37 +/- ##
==========================================
+ Coverage 86.72% 87.34% +0.61%
==========================================
Files 14 14
Lines 633 664 +31
==========================================
+ Hits 549 580 +31
Misses 84 84
Continue to review full report in Codecov by Sentry.
|
mickel8
force-pushed
the
update-config
branch
13 times, most recently
from
0fd7395 to
6866f25
Compare
mickel8
commented
Dec 13, 2023
Comment on lines
-204
to
-212
| @spec get_extensions(ExSDP.t()) :: %{(id :: non_neg_integer()) => extension() | :unknown} | ||
| @spec get_extensions(ExSDP.t()) :: [Extmap.t()] | ||
| def get_extensions(sdp) do | ||
| # we assume that, if extension is present in multiple mlines, the IDs are the same (RFC 8285) | ||
| sdp.media | ||
| |> Enum.flat_map(&ExSDP.Media.get_attributes(&1, :extmap)) | ||
| |> Map.new(fn extmap -> | ||
| # TODO: handle direction and extension attributes | ||
| ext = urn_to_extension(extmap.uri) | ||
| {extmap.id, ext} |
Contributor
Author
There was a problem hiding this comment.
I changed the implementation as:
- now I can reuse
get_extensionsin Configuration - for now it seems to be good enough to operate on
ExSDP.Attribute.Extmapinstead of{Extension.SourceDescription, :mid/:cname}.
mickel8
force-pushed
the
update-config
branch
3 times, most recently
from
3577bf1 to
9cdab00
Compare
LVala
approved these changes
Dec 14, 2023
mickel8
force-pushed
the
update-config
branch
from
696e227 to
5242870
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of things still won't work e.g.:
but I think this is good enough improvement to be merged