Skip to content

Conversation

@LVala
Copy link
Contributor

@LVala LVala commented Jul 26, 2024

No description provided.

@LVala LVala self-assigned this Jul 26, 2024
@LVala LVala force-pushed the fix/video-tile-resizing branch from a021724 to 92a76da Compare July 26, 2024 12:34
@LVala LVala requested a review from mickel8 July 26, 2024 12:37
@mickel8
Copy link
Contributor

mickel8 commented Jul 29, 2024

I replaced flex-none in chat and settings divs by flex-1 in videoWrapper. This way, videoWrapper will grow as much as possible and will also shrink at first. When videoWrapper disappers, our chat will start shrinking.

I also fixed the problem with videoWrapper not being re-displayed after we show chat on small screens (< 1024) that are then resized to large screens (> 1024)

I mean flow:

  1. Resize screen to be < 1024
  2. Show chat - because we are on small screen videoWrapper is hidden
  3. Resize screen to be > 1024
  4. Now videoWrapper will be re-displayed

@mickel8 mickel8 merged commit 675b099 into master Jul 29, 2024
@mickel8 mickel8 deleted the fix/video-tile-resizing branch July 29, 2024 16:00
@mickel8 mickel8 linked an issue Jul 29, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Broadcaster] Video tile resizes when switching between simulcast layers

3 participants