Skip to content

Raise if using an in memory database with pool_size != 1 #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 5, 2023
Merged

Raise if using an in memory database with pool_size != 1 #128

merged 3 commits into from
Oct 5, 2023

Conversation

@mdwaud
Copy link
Contributor

@mdwaud mdwaud commented Oct 4, 2023

Related to #75

warmwaffles
warmwaffles approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@warmwaffles warmwaffles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good add. Would save a lot of people from a footgun.

warmwaffles
warmwaffles reviewed Oct 4, 2023
View reviewed changes
@warmwaffles warmwaffles merged commit f9fdfa5 into elixir-sqlite:main Oct 5, 2023
@mdwaud mdwaud deleted the raise-for-in-memory-pool-size branch October 5, 2023 18:33
@ckampfe ckampfe mentioned this pull request Oct 31, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@warmwaffles warmwaffles warmwaffles approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mdwaud @warmwaffles