Remove remaining swup:page:view listeners #2070
Conversation
|
📦 Docs artifacts are ready: https://github.com/elixir-lang/ex_doc/actions/runs/12966482187/artifacts/2485303286 |
|
|
||
| // Keep updated with future changes. | ||
| window.addEventListener('hashchange', markCurrentHashInSidebar) | ||
| window.addEventListener('exdoc:loaded', markCurrentHashInSidebar) |
There was a problem hiding this comment.
Doesn't this mean markCurrentHashInSidebar will be invoked two times on boot? One here and another on DOMContentLoaded? Or is that fine?
There was a problem hiding this comment.
Calling multiple times is fine but I don't think it should happen.
On page load this would be called by the sidebar init fn which is now triggered by ex doc:loaded, meaning the event has already fired at this point and won't fire again until SWUP nav.
That's why it broke when you tried it. Adding the listener here is too late for the first render.
There was a problem hiding this comment.
Got it! Thanks for clarifying and sorry for being a slowpoke!
|
💚 💙 💜 💛 ❤️ |
2 participants
Re: #2069 (comment)
The sidebar-list is lazy-rendered so will always be called after the first
exdoc:loadedevent.I re-arranged a few lines and added some comments to make it more obvious that it's not the standard
exdoc:loaded->init()pattern.