Add support for cross lateral joins. #4054
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you. This would also require a change in ecto_sql otherwise the postgres adapter won't understand the join qualifier: https://github.com/elixir-ecto/ecto_sql/blob/master/lib/ecto/adapters/postgres/connection.ex#L515 |
Thank you! I was just finishing the ecto_sql PR. |
josevalim
approved these changes
Nov 23, 2022
wilkinson4
force-pushed
the
ww/add-cross-lateral-join-support
branch
from
f686891 to
c6fe81f
Compare
wilkinson4
force-pushed
the
ww/add-cross-lateral-join-support
branch
from
c6fe81f to
ca40842
Compare
wilkinson4
force-pushed
the
ww/add-cross-lateral-join-support
branch
from
ca40842 to
6488728
Compare
|
Fixed a broken test. Ran it locally this time to make sure we're good. 😅 One more time if you wouldn't mind please. |
|
Thank you! Please use the commit from master in your ecto_sql PR then we should be good to go :) |
greg-rychlewski
pushed a commit
to greg-rychlewski/ecto
that referenced
this pull request
Dec 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into a case where we needed to use a Postgres Cross Join Lateral. Figured I would make a PR to allow Ecto to support it. The reason we needed it is because we have had multiple situations that fit this stackoverflow post's answer