Skip to content

Conversation

@true0r
Copy link
Contributor

@true0r true0r commented Aug 12, 2019

I use yarn with enabled plug’n’play option, it means that node_modules directory doesn't exist instead used .php.js file.

if (forceInstall || !(await pathExists(path.join(appDir, "node_modules")))) {
await installDependencies(appDir, effectiveOptions)
}

File contains a path resolver and mapping to dependencies paths (include devDependencies). When electron-builder calls installDependencies then .php.js file will be overwritten (without devDependencies) that break process because builder needs in devDependencies on runtime.

const execArgs = ["install", "--production"]

@develar develar merged commit 0fe8f12 into electron-userland:master Sep 23, 2019
@dbkr dbkr mentioned this pull request Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants