[DOCS] Updates TLS tutorial for use with basic licenses and new cluster formation settings #358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaveCTurner
reviewed
Jun 7, 2019
Contributor
DaveCTurner
left a comment
DaveCTurner
left a comment
There was a problem hiding this comment.
I suggested a change re. cluster.initial_master_nodes. The details of setting up security are outside what I can definitively review, so I'll leave that to Tim.
docs/en/stack/security/securing-communications/tutorial-tls-addnodes.asciidoc
Outdated
Show resolved
Hide resolved
tvernum
approved these changes
Jun 19, 2019
Contributor
tvernum
left a comment
tvernum
left a comment
There was a problem hiding this comment.
LGTM, with a couple of minor points.
| . (Optional) Restart {kib}. For example, if you installed | ||
| {kib} with a `.tar.gz` package, run the following command from the {kib} | ||
| directory: | ||
| . Create passwords for the built-in users and . |
Contributor
There was a problem hiding this comment.
This sentence finished halfway through.
Contributor
Author
There was a problem hiding this comment.
Thanks for catching that!
docs/en/stack/security/securing-communications/tutorial-tls-internode.asciidoc
Outdated
Show resolved
Hide resolved
docs/en/stack/security/securing-communications/tutorial-tls-internode.asciidoc
Outdated
Show resolved
Hide resolved
docs/en/stack/security/securing-communications/tutorial-tls-addnodes.asciidoc
Outdated
Show resolved
Hide resolved
…ternode.asciidoc Co-Authored-By: Tim Vernum <[email protected]>
…ternode.asciidoc Co-Authored-By: Tim Vernum <[email protected]>
…dnodes.asciidoc Co-Authored-By: Tim Vernum <[email protected]>
lcawl
added a commit
that referenced
this pull request
Jun 20, 2019
…er formation settings (#358) Co-Authored-By: Tim Vernum <[email protected]>
lcawl
added a commit
that referenced
this pull request
Jun 20, 2019
…er formation settings (#358) Co-Authored-By: Tim Vernum <[email protected]>
lcawl
added a commit
that referenced
this pull request
Jun 20, 2019
…er formation settings (#358) Co-Authored-By: Tim Vernum <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the TLS tutorial (https://www.elastic.co/guide/en/elastic-stack-overview/master/encrypting-internode-communications.html) such that it: