Skip to content

Conversation

@lcawl
Copy link
Contributor

@lcawl lcawl commented Feb 25, 2019

This PR addresses a difference in the way Asciidoc and Asciidoctor handle sections that do not have anchors explicitly defined. In particular:

<a id="_whats_next">
vs
<a id="_what_8217_s_next">

This PR explicitly defines an anchor rather than relying on generated text.

@lcawl lcawl requested a review from nik9000 February 25, 2019 23:48
@lcawl lcawl merged commit 3928a1a into elastic:master Feb 26, 2019
@lcawl lcawl deleted the gs-asciidoctor-link branch February 26, 2019 00:25
lcawl added a commit that referenced this pull request Feb 26, 2019
lcawl added a commit that referenced this pull request Feb 26, 2019
lcawl added a commit that referenced this pull request Feb 26, 2019
lcawl added a commit that referenced this pull request Feb 26, 2019
lcawl added a commit that referenced this pull request Feb 26, 2019
lcawl added a commit that referenced this pull request Feb 26, 2019
lcawl added a commit that referenced this pull request Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant