Skip to content

Conversation

@simianhacker
Copy link
Member

This PR adds definitions for each of the metrics (CPU Usage, Memory Usage, etc) for each of the node types (Hosts, Containers, Pods) available in the waffle map per #156

[float]
==== Which fields are used for the metrics on the map?


Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dedemorton I feel like there should be some text here but I'm not sure what it should be. Maybe something about how using Beat Shippers listed above automatically sends these fields. Along with these fields, documents must also contain the identifying fields for each node type (host, container, pod).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. In fact, you need to have text here, or the doc build fails.

Copy link
Contributor

@dedemorton dedemorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simianhacker I've added some comments related to doc build issues, but before I suggest content changes, I wanted to check with Brandon to see if he wants to do the review. The idea is that I will focus on the shipper side of the docs, and he will focus on the UI.

@bmorelli25 Can you take over this review?

[float]
==== Which fields are used for the metrics on the map?


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. In fact, you need to have text here, or the doc build fails.

Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋@simianhacker

I suggested a few grammar related revisions below. It's tough for me to review the content of this PR as my knowledge of the infrastructure monitoring capabilities of the Elastic stack is limited to what I've read in the documentation. At some point, when you have time, we should zoom and chat about the solution. A walkthrough of the UI would be awesome as well.

@simianhacker
Copy link
Member Author

@bmorelli25 Thanks for the suggestions. That is so much easier the the usually back and forth :D

@simianhacker
Copy link
Member Author

@dedemorton I will add @bmorelli25 and remove you from the reviewers for this PR. Thank you for taking a look and connecting this to the right eyeballs 👁 👁

Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simianhacker
Copy link
Member Author

@DanRoscigno Can you take a look at this PR and let me know if that works for you?

@DanRoscigno
Copy link
Contributor

Yes, will do today!

@simianhacker simianhacker merged commit 36453a5 into elastic:master Feb 14, 2019
simianhacker added a commit to simianhacker/stack-docs that referenced this pull request Feb 14, 2019
Update Infrastructure UI documentation with metric definitions
simianhacker added a commit to simianhacker/stack-docs that referenced this pull request Feb 14, 2019
Update Infrastructure UI documentation with metric definitions
simianhacker added a commit to simianhacker/stack-docs that referenced this pull request Feb 14, 2019
Update Infrastructure UI documentation with metric definitions
simianhacker added a commit to simianhacker/stack-docs that referenced this pull request Feb 14, 2019
Update Infrastructure UI documentation with metric definitions
simianhacker added a commit that referenced this pull request Feb 14, 2019
Update Infrastructure UI documentation with metric definitions
simianhacker added a commit that referenced this pull request Feb 14, 2019
Update Infrastructure UI documentation with metric definitions
simianhacker added a commit that referenced this pull request Feb 14, 2019
Update Infrastructure UI documentation with metric definitions
simianhacker added a commit that referenced this pull request Feb 14, 2019
Update Infrastructure UI documentation with metric definitions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants