-
Notifications
You must be signed in to change notification settings - Fork 254
Update Infrastructure UI documentation with metric definitions #210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| [float] | ||
| ==== Which fields are used for the metrics on the map? | ||
|
|
||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dedemorton I feel like there should be some text here but I'm not sure what it should be. Maybe something about how using Beat Shippers listed above automatically sends these fields. Along with these fields, documents must also contain the identifying fields for each node type (host, container, pod).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. In fact, you need to have text here, or the doc build fails.
dedemorton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@simianhacker I've added some comments related to doc build issues, but before I suggest content changes, I wanted to check with Brandon to see if he wants to do the review. The idea is that I will focus on the shipper side of the docs, and he will focus on the UI.
@bmorelli25 Can you take over this review?
| [float] | ||
| ==== Which fields are used for the metrics on the map? | ||
|
|
||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. In fact, you need to have text here, or the doc build fails.
bmorelli25
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggested a few grammar related revisions below. It's tough for me to review the content of this PR as my knowledge of the infrastructure monitoring capabilities of the Elastic stack is limited to what I've read in the documentation. At some point, when you have time, we should zoom and chat about the solution. A walkthrough of the UI would be awesome as well.
Co-Authored-By: simianhacker <[email protected]>
|
@bmorelli25 Thanks for the suggestions. That is so much easier the the usually back and forth :D |
|
@dedemorton I will add @bmorelli25 and remove you from the reviewers for this PR. Thank you for taking a look and connecting this to the right eyeballs 👁 👁 |
bmorelli25
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@DanRoscigno Can you take a look at this PR and let me know if that works for you? |
|
Yes, will do today! |
Update Infrastructure UI documentation with metric definitions
Update Infrastructure UI documentation with metric definitions
Update Infrastructure UI documentation with metric definitions
Update Infrastructure UI documentation with metric definitions
Update Infrastructure UI documentation with metric definitions
Update Infrastructure UI documentation with metric definitions
Update Infrastructure UI documentation with metric definitions
Update Infrastructure UI documentation with metric definitions
This PR adds definitions for each of the metrics (CPU Usage, Memory Usage, etc) for each of the node types (Hosts, Containers, Pods) available in the waffle map per #156