[DOCS] Adds breaking changes page with content re-use #197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 2, 2019
lcawl
force-pushed
the
notable-breaking
branch
from
8b5393a to
bfa5cf4
Compare
7 tasks
lcawl
force-pushed
the
notable-breaking
branch
from
b53e1fb to
4530894
Compare
This was referenced Mar 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a "Breaking Changes" page to the Installation and Upgrade Guide (https://www.elastic.co/guide/en/elastic-stack/master/index.html) and lays the groundwork for adding highlighted breaking changes from across the stack to this book.
After we move to an Asciidoctor build for this book, we can use tagged regions to pull in content from breaking change pages across the library (per https://asciidoctor.org/docs/user-manual/#by-tagged-regions). At that time, the build command will need to change as follows (with --resources parameters added for each repo we pull from):
docbldstk --resource=elasticsearch/docs --resource=kibana/docs --asciidoctor
NOTE: The presence of these tagged regions cannot be processed by our current asciidoc builds, thus the following line must be added to the index.asciidoc to preview the tagged regions: