[DOCS] Add OS/architecture classifier to distributions #194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dedemorton
approved these changes
Jan 31, 2019
Contributor
dedemorton
left a comment
dedemorton
left a comment
There was a problem hiding this comment.
LGTM, though I am only eyeballing the package names since they aren't available yet.
rjernst
approved these changes
Feb 1, 2019
Member
rjernst
left a comment
rjernst
left a comment
There was a problem hiding this comment.
Looks good but one small thing to correct
| ---------------------------------------------------------------------- | ||
| curl -L -O https://artifacts.elastic.co/downloads/elasticsearch/elasticsearch-{elasticsearch_version}-linux-x86_64.tar.gz | ||
| tar -xzvf elasticsearch-{elasticsearch_version}-linux-x86_64.tar.gz | ||
| cd elasticsearch-{elasticsearch_version}-linux-x86_64 |
Member
There was a problem hiding this comment.
The extracted directory name hasn't changed, so this should still be elasticsearch-{elasticsearch_version}
Contributor
Author
There was a problem hiding this comment.
Thanks @rjernst I implemented those changes
| ["source","sh",subs="attributes,callouts"] | ||
| ---------------------------------------------------------------------- | ||
| cd C:\Program Files\elasticsearch-{elasticsearch_version} | ||
| cd C:\Program Files\elasticsearch-{elasticsearch_version}-windows-x86_64 |
Member
There was a problem hiding this comment.
same here, the extracted directory isn't changing
| cd elasticsearch-{elasticsearch_version} | ||
| curl -L -O https://artifacts.elastic.co/downloads/elasticsearch/elasticsearch-{elasticsearch_version}-darwin-x86_64.tar.gz | ||
| tar -xzvf elasticsearch-{elasticsearch_version}-darwin-x86_64.tar.gz | ||
| cd elasticsearch-{elasticsearch_version}-darwin-x86_64 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to elastic/elasticsearch#37881
This PR updates the installation package names in the stack-docs repo. For example, it adds a new Linux section to https://www.elastic.co/guide/en/elastic-stack-get-started/master/get-started-elastic-stack.html#install-elasticsearch