[DOCS] Replaces X-Pack security terminology #187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
tvernum
reviewed
Jan 25, 2019
Contributor
tvernum
left a comment
tvernum
left a comment
There was a problem hiding this comment.
I left a couple of suggestions
| Authorization is the process of determining whether the user behind an incoming | ||
| request is allowed to execute the request. | ||
| The {stack-security-features} introduce the concept of _authorization_ to the | ||
| {stack}. Authorization is the process of determining whether the user behind an |
Contributor
There was a problem hiding this comment.
The repeated use of "stack" feels a little off. We may need to phrase this quite differently if we to avoid describing {security} as being something extra that's added to the stack.
Maybe:
The {stack-security-features} include support for the concept of _authorization_.
?
Contributor
Author
There was a problem hiding this comment.
Thanks @tvernum , I change it to: "The {stack-security-features} add authorization, which is the process of determining whether the user..."
lcawl
added a commit
that referenced
this pull request
Mar 4, 2019
lcawl
added a commit
that referenced
this pull request
Mar 4, 2019
lcawl
added a commit
that referenced
this pull request
Mar 4, 2019
lcawl
added a commit
that referenced
this pull request
Mar 4, 2019
lcawl
added a commit
that referenced
this pull request
Mar 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to elastic/docs#407
This PR replaces occurrences of {security} or "X-Pack Security" with the new {security-features}, {stack-security-features}, or {es-security-features} terminology.