Add section for misconfigured sp entity id #160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This started popping up quite a lot in cloud, with the culprit usually being trailing slashes in the SP entity ID that is set in either `elasticsearch.yml` or the IdP configuration.
Contributor
|
LGTM. (Can't officially review on mobile) |
lcawl
approved these changes
Dec 3, 2018
Contributor
lcawl
left a comment
lcawl
left a comment
There was a problem hiding this comment.
LGTM (I pushed a few formatting changes then verified the output)
tvernum
approved these changes
Dec 4, 2018
jkakavas
added a commit
that referenced
this pull request
Dec 4, 2018
Add section for misconfigured sp entity id
jkakavas
added a commit
that referenced
this pull request
Dec 4, 2018
Add section for misconfigured sp entity id
jkakavas
added a commit
that referenced
this pull request
Dec 4, 2018
Add section for misconfigured sp entity id
jkakavas
added a commit
that referenced
this pull request
Dec 4, 2018
Add section for misconfigured sp entity id
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This started popping up quite a lot in cloud, with the culprit
usually being trailing slashes in the SP entity ID that is set
in either
elasticsearch.ymlor the IdP configuration.