[ML] Upgrade Gradle Wrapper to use version 6.0.1 #891
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elasticsearch has recently upgraded to version 6.0.1 (see elastic/elasticsearch#49211) and it's best if the ml-cpp repo is consistent at least in the major version of Gradle that is used. When ml-cpp is built alongside elasticsearch via the elasticsearch-extra directory it will be using the Gradle chosen by the elasticsearch repo, so it's best if that version is also used when building ml-cpp standalone to avoid integration incompatibilities.
droberts195
pushed a commit
to droberts195/ml-cpp
that referenced
this pull request
Dec 11, 2019
Elasticsearch has recently upgraded to version 6.0.1 (see elastic/elasticsearch#49211) and it's best if the ml-cpp repo is consistent at least in the major version of Gradle that is used. When ml-cpp is built alongside elasticsearch via the elasticsearch-extra directory it will be using the Gradle chosen by the elasticsearch repo, so it's best if that version is also used when building ml-cpp standalone to avoid integration incompatibilities. Backport of elastic#891
droberts195
pushed a commit
that referenced
this pull request
Dec 13, 2019
Elasticsearch has recently upgraded to version 6.0.1 (see elastic/elasticsearch#49211) and it's best if the ml-cpp repo is consistent at least in the major version of Gradle that is used. When ml-cpp is built alongside elasticsearch via the elasticsearch-extra directory it will be using the Gradle chosen by the elasticsearch repo, so it's best if that version is also used when building ml-cpp standalone to avoid integration incompatibilities. Backport of #891
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Elasticsearch has recently upgraded to version 6.0.1
(see elastic/elasticsearch#49211) and it's best if
the ml-cpp repo is consistent at least in the major
version of Gradle that is used.
When ml-cpp is built alongside elasticsearch via the
elasticsearch-extra directory it will be using the
Gradle chosen by the elasticsearch repo, so it's
best if that version is also used when building ml-cpp
standalone to avoid integration incompatibilities.