Skip to content

[ML] Remove old clang workaround #883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 10, 2019
Merged

[ML] Remove old clang workaround #883

merged 2 commits into from
Dec 10, 2019

Conversation

@droberts195
Copy link

@droberts195 droberts195 commented Dec 10, 2019

This is no longer required after #867

[ML] Remove old clang workaround
a7a8f67 
This is no longer required after elastic#867
edsavage
edsavage approved these changes Dec 10, 2019
View reviewed changes
Copy link
Contributor

@edsavage edsavage left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (apart from the clang-format error causing CI to fail ;-) )

@droberts195 droberts195 merged commit d3063f2 into elastic:master Dec 10, 2019
@droberts195 droberts195 deleted the remove_clang_workaround branch December 10, 2019 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@edsavage edsavage edsavage approved these changes

Assignees

No one assigned

Labels

:ml >non-issue v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@droberts195 @edsavage