[ML] Rename anonymous namespace apply function to avoid clash #871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In C++17 there is a std::apply function that gets chosen in preference to the apply function in the anonymous namespace in the metric and event rate bucket gatherers. This change renames our function so the compiler does not have to resolve an ambiguity when it's called.
Author
|
Exactly the same clash was observed on Windows in #834 and on macOS in #867, so this must be a C++17 thing rather than a quirk of one of the compilers. Even though C++17 changes are only essential in master, it doesn't hurt to backport to 7.x too, which will reduce the chance of future backport clashes. |
droberts195
pushed a commit
to droberts195/ml-cpp
that referenced
this pull request
Dec 2, 2019
In C++17 there is a std::apply function that gets chosen in preference to the apply function in the anonymous namespace in the metric and event rate bucket gatherers. This change renames our function so the compiler does not have to resolve an ambiguity when it's called. Backport of elastic#871
droberts195
pushed a commit
that referenced
this pull request
Dec 2, 2019
In C++17 there is a std::apply function that gets chosen in preference to the apply function in the anonymous namespace in the metric and event rate bucket gatherers. This change renames our function so the compiler does not have to resolve an ambiguity when it's called. Backport of #871
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In C++17 there is a std::apply function that gets chosen in
preference to the apply function in the anonymous namespace
in the metric and event rate bucket gatherers.
This change renames our function so the compiler does not
have to resolve an ambiguity when it's called.