[ML] Change brace placement in shell scripts #83
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes brace placement for functions in shell scripts to match the style that was introduced for the C++ code in elastic#15.
edsavage
approved these changes
May 2, 2018
Contributor
edsavage
left a comment
edsavage
left a comment
There was a problem hiding this comment.
LGTM
One thing I have noticed though is that both these shell scripts share a lot of common functionality - it might be nice to pull that out into a separate module at some point in the future to reduce the effort of maintenance tasks such as this one.
droberts195
pushed a commit
that referenced
this pull request
May 2, 2018
This changes brace placement for functions in shell scripts to match the style that was introduced for the C++ code in #15.
droberts195
pushed a commit
that referenced
this pull request
May 2, 2018
This changes brace placement for functions in shell scripts to match the style that was introduced for the C++ code in #15.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes brace placement for functions in shell scripts to
match the style that was introduced for the C++ code in #15.