[ML] Replace std::auto_ptr with std::unique_ptr #717
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
std::auto_ptr has been removed from C++17, so we need to stop using it before we can upgrade to C++17. Also corrected the type name of a typedef of a std::auto_ptr.
droberts195
pushed a commit
to droberts195/ml-cpp
that referenced
this pull request
Oct 4, 2019
std::auto_ptr has been removed from C++17, so we need to stop using it before we can upgrade to C++17. Also corrected the type name of a typedef of a std::auto_ptr. Backport of elastic#717
droberts195
pushed a commit
that referenced
this pull request
Oct 4, 2019
std::auto_ptr has been removed from C++17, so we need to stop using it before we can upgrade to C++17. Also corrected the type name of a typedef of a std::auto_ptr. Backport of #717
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std::auto_ptr has been removed from C++17, so we need
to stop using it before we can upgrade to C++17.
Also corrected the type name of a typedef of a
std::auto_ptr.