Skip to content

[ML] Rename outlier detection method values #598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 21, 2019
Merged

[ML] Rename outlier detection method values #598

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
781a2fd
[ML] Rename outlier detection method values
dimitris-athanasiou Aug 19, 2019
dbd70af
Add to changelog
dimitris-athanasiou Aug 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions docs/CHANGELOG.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,13 @@

//=== Regressions

== {es} version 7.4.0

=== Bug Fixes

* Rename outlier detection method values knn and tnn to distance_kth_nn and distance_knn
respectively to match the API. (See {ml-pull}598[#598].)

== {es} version 7.3.1

=== Bug Fixes
Expand Down
4 changes: 2 additions & 2 deletions lib/api/CDataFrameOutliersRunner.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,8 @@ const std::string OUTLIER_FRACTION{"outlier_fraction"};
const CDataFrameAnalysisConfigReader PARAMETER_READER{[] {
const std::string lof{"lof"};
const std::string ldof{"ldof"};
const std::string knn{"knn"};
const std::string tnn{"tnn"};
const std::string knn{"distance_kth_nn"};
const std::string tnn{"distance_knn"};
CDataFrameAnalysisConfigReader theReader;
theReader.addParameter(STANDARDIZE_COLUMNS,
CDataFrameAnalysisConfigReader::E_OptionalParameter);
Expand Down
2 changes: 1 addition & 1 deletion lib/api/unittest/CDataFrameAnalyzerTest.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -464,7 +464,7 @@ void CDataFrameAnalyzerTest::testRunOutlierDetectionWithParams() {
// Test the method and number of neighbours parameters are correctly
// propagated to the analysis runner.

TStrVec methods{"lof", "ldof", "knn", "tnn"};
TStrVec methods{"lof", "ldof", "distance_kth_nn", "distance_knn"};

for (const auto& method :
{maths::COutliers::E_Lof, maths::COutliers::E_Ldof,
Expand Down