Skip to content

[ML] boost::function cannot be initialised with nullptr #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 9, 2018
Merged

[ML] boost::function cannot be initialised with nullptr #47

merged 1 commit into from
Apr 9, 2018

Conversation

@davidkyle
Copy link
Member

@davidkyle davidkyle commented Apr 9, 2018

This fixes a compilation failure introduced backporting the 0 -> nullptr changes.

The 7.0 branch uses std::function which has a conversion from nullptr boost::function does not

hendrikmuhs
hendrikmuhs approved these changes Apr 9, 2018
View reviewed changes
Copy link

@hendrikmuhs hendrikmuhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidkyle davidkyle merged this pull request into elastic:6.x Apr 9, 2018
@davidkyle davidkyle deleted the fix-func-ptr branch April 9, 2018 16:48
@sophiec20 sophiec20 added the :ml label Apr 9, 2018
droberts195 pushed a commit that referenced this pull request Apr 23, 2018
@davidkyle
[ML] boost::function cannot be initialised with nullptr (#47)
66c18ea 
This fixes a compilation failure introduced backporting the 0 -> nullptr changes.
The 7.0 branch uses std::function which has a conversion from nullptr boost::function does not
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@hendrikmuhs hendrikmuhs hendrikmuhs approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

:ml >non-issue review v6.3.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@davidkyle @hendrikmuhs @sophiec20