[ML] Add the "time" syscall to the syscall filter #459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required with the Oracle Unbreakable Enterprise Kernel (UEK). The UEK is not supported but it's possible some other supported Linux distro will require the "time" syscall at some point, so it doesn't hurt to permit it in our filter. Fixes elastic/elasticsearch#41101
davidkyle
approved these changes
Apr 11, 2019
Member
davidkyle
left a comment
davidkyle
left a comment
There was a problem hiding this comment.
LGTM, there is some debugging code left in there to be removed
| #define SECCOMP_RET_ERRNO 0x00050000U | ||
| #define SECCOMP_RET_ALLOW 0x7fff0000U | ||
| #define SECCOMP_RET_DATA 0x0000ffffU | ||
| #define SECCOMP_RET_KILL 0x00000000U |
Author
There was a problem hiding this comment.
I left it in to avoid having to look it up next time we need to debug. It doesn't really hurt, and can be removed when all the constants are removed once our minimum build machine has the header containing the constants.
droberts195
pushed a commit
to droberts195/ml-cpp
that referenced
this pull request
Apr 11, 2019
This is required with the Oracle Unbreakable Enterprise Kernel (UEK). The UEK is not supported but it's possible some other supported Linux distro will require the "time" syscall at some point, so it doesn't hurt to permit it in our filter. Fixes elastic/elasticsearch#41101 Backport of elastic#459
droberts195
pushed a commit
to droberts195/ml-cpp
that referenced
this pull request
Apr 11, 2019
This is required with the Oracle Unbreakable Enterprise Kernel (UEK). The UEK is not supported but it's possible some other supported Linux distro will require the "time" syscall at some point, so it doesn't hurt to permit it in our filter. Fixes elastic/elasticsearch#41101 Backport of elastic#459
droberts195
pushed a commit
to droberts195/ml-cpp
that referenced
this pull request
Apr 11, 2019
This is required with the Oracle Unbreakable Enterprise Kernel (UEK). The UEK is not supported but it's possible some other supported Linux distro will require the "time" syscall at some point, so it doesn't hurt to permit it in our filter. Fixes elastic/elasticsearch#41101 Backport of elastic#459
This was referenced Apr 11, 2019
droberts195
pushed a commit
that referenced
this pull request
Apr 11, 2019
This is required with the Oracle Unbreakable Enterprise Kernel (UEK). The UEK is not supported but it's possible some other supported Linux distro will require the "time" syscall at some point, so it doesn't hurt to permit it in our filter. Fixes elastic/elasticsearch#41101 Backport of #459
droberts195
pushed a commit
that referenced
this pull request
Apr 11, 2019
This is required with the Oracle Unbreakable Enterprise Kernel (UEK). The UEK is not supported but it's possible some other supported Linux distro will require the "time" syscall at some point, so it doesn't hurt to permit it in our filter. Fixes elastic/elasticsearch#41101 Backport of #459
droberts195
pushed a commit
that referenced
this pull request
Apr 11, 2019
This is required with the Oracle Unbreakable Enterprise Kernel (UEK). The UEK is not supported but it's possible some other supported Linux distro will require the "time" syscall at some point, so it doesn't hurt to permit it in our filter. Fixes elastic/elasticsearch#41101 Backport of #459
droberts195
pushed a commit
to droberts195/elasticsearch
that referenced
this pull request
Apr 15, 2019
The cause of failure was fixed by elastic/ml-cpp#459, so all that remains on the Java side is to unmute the test that was failing. Closes elastic#41070
droberts195
pushed a commit
to elastic/elasticsearch
that referenced
this pull request
Apr 16, 2019
The cause of failure was fixed by elastic/ml-cpp#459, so all that remains on the Java side is to unmute the test that was failing. Closes #41070
droberts195
pushed a commit
to elastic/elasticsearch
that referenced
this pull request
Apr 16, 2019
The cause of failure was fixed by elastic/ml-cpp#459, so all that remains on the Java side is to unmute the test that was failing. Closes #41070
droberts195
pushed a commit
to elastic/elasticsearch
that referenced
this pull request
Apr 16, 2019
The cause of failure was fixed by elastic/ml-cpp#459, so all that remains on the Java side is to unmute the test that was failing. Closes #41070
droberts195
pushed a commit
to elastic/elasticsearch
that referenced
this pull request
Apr 16, 2019
The cause of failure was fixed by elastic/ml-cpp#459, so all that remains on the Java side is to unmute the test that was failing. Closes #41070
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
The cause of failure was fixed by elastic/ml-cpp#459, so all that remains on the Java side is to unmute the test that was failing. Closes elastic#41070
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required with the Oracle Unbreakable
Enterprise Kernel (UEK). The UEK is not
supported but it's possible some other
supported Linux distro will require the "time"
syscall at some point, so it doesn't hurt to
permit it in our filter.
Fixes elastic/elasticsearch#41101