Skip to content

Conversation

@lcawl
Copy link
Contributor

@lcawl lcawl commented Dec 17, 2018

This PR removes the 6.x items from the changelog in master and adds PRs that are closed with the v7.0.0 label. It omits PRs that were labelled with release numbers that are already generally available.

//=== Regressions
* Fixes CPoissonMeanConjugate sampling error. {ml-pull}335[#335]
* Removes out-of-phase buckets feature. {ml-pull}318[#318] (issue: {ml-issue}302[#302])

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We deliberately decided not to document this as the removed feature was never documented or tested and nobody should ever have used it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok! I've added "non-issue" so it doesn't get picked up.

* Linear scaling change detection. {ml-pull}25[#25]
* Implements an absolute goodness-of-fit test to accept a change. {ml-pull}21[#21]
* Wires in change detection/modelling to our univariate time series model. {ml-pull}11[#11]
* First pass implementation of support functionality for change detection and modelling. {ml-pull}9[#9]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#9, #11, #21 and #25 were feature branch PRs that eventually got merged into the main release branches in #92 in time for 6.4.

So #9, #11, #21 and #25 should be removed from here.

Sorry for the wasted effort. In future we'll endeavour not to put version labels on feature branch PRs.

Fix cause of "MERGE: Sum mode samples = 0, total samples = 4.43521.." log errors ({ml-pull}294[294])
//=== Regressions
* Fixes CPoissonMeanConjugate sampling error. {ml-pull}335[#335]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's true that this isn't currently in a GA version, but it will be in 6.6. So when the eventual 7.0.0 GA release notes are created it shouldn't be in there. Might it be worth adding a comment here to say it should be removed when consolidating into the GA 7.0.0 release notes?

@lcawl
Copy link
Contributor Author

lcawl commented Dec 18, 2018

Thanks @droberts195, I've cleaned up the list based on your feedback

Copy link

@droberts195 droberts195 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lcawl lcawl merged commit 0d5e131 into elastic:master Dec 18, 2018
@lcawl lcawl deleted the a2-release-notes branch December 18, 2018 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants