[FEATURE][ML] change artifactname in order to create a CI build job #344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with master builds
Contributor
|
Could we leave a TODO so this isn't missed |
Contributor
|
I have raised an issue to track those and I added it there |
Contributor
|
Ignore the nix failure: it is #343 |
hendrikmuhs
pushed a commit
to elastic/elasticsearch
that referenced
this pull request
Dec 18, 2018
change the download location to load the custom binaries created in elastic/ml-cpp#344
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes the artifact name to
ml-cpp-dfin order setup a CI build that uploads builds without clashing with master buildsBefore the feature branch is merged, this change must be reverted.
@dimitris-athanasiou