[ML] Standardise on not using explicit void argument lists #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tveasey
added a commit
that referenced
this pull request
Apr 4, 2018
We've started mixing explicit void and empty argument lists. For C++ they are equivalent. If we needed C headers for any of our existing functionality we'd almost certainly have to provide a wrapper API anyway. Therefore, this change switches to empty argument lists on the grounds that it is less typing.
droberts195
pushed a commit
that referenced
this pull request
Apr 23, 2018
We've started mixing explicit void and empty argument lists. For C++ they are equivalent. If we needed C headers for any of our existing functionality we'd almost certainly have to provide a wrapper API anyway. Therefore, this change switches to empty argument lists on the grounds that it is less typing.
droberts195
pushed a commit
that referenced
this pull request
Apr 23, 2018
We've started mixing explicit void and empty argument lists. For C++ they are equivalent. If we needed C headers for any of our existing functionality we'd almost certainly have to provide a wrapper API anyway. Therefore, this change switches to empty argument lists on the grounds that it is less typing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on from #32, we've started mixing explicit void and empty argument lists. For C++ they are equivalent. If we needed C headers for any of our existing functionality we'd almost certainly have to provide a wrapper API anyway. Therefore, this change switches to empty argument lists on the grounds that it is less typing.