[ML] Standardise on cmath header #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
droberts195
approved these changes
Apr 3, 2018
droberts195
left a comment
droberts195
left a comment
There was a problem hiding this comment.
LGTM
This shows up quite a lot of files where we were relying on an indirect include of math.h and still are for cmath, but that's not a problem introduced by this change.
Contributor
Author
|
Yes, I thought the same. I think we have quite a few implicit include dependencies, aside from these. On another project on which I worked, we wrote a tool to push down headers as far as possible through the include DAG, whilst checking compilation. Aside from avoiding implicit includes, it was also useful for reducing overall compile time. This might be something to consider at some point. Since it is clear in which files the |
tveasey
added a commit
that referenced
this pull request
Apr 4, 2018
This switches to use the cmath rather than math.h header. This only guaranties to declare special functions in the std namespace, so this also adds std:: qualification on existing calls.
droberts195
pushed a commit
that referenced
this pull request
Apr 23, 2018
This switches to use the cmath rather than math.h header. This only guaranties to declare special functions in the std namespace, so this also adds std:: qualification on existing calls.
droberts195
pushed a commit
that referenced
this pull request
Apr 23, 2018
This switches to use the cmath rather than math.h header. This only guaranties to declare special functions in the std namespace, so this also adds std:: qualification on existing calls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on from #32. This switches to use the
cmathrather thanmath.hheader. This only guaranties to declare special maths functions in the std namespace, so this also addsstd::qualification on existing calls. The rationale for this is that 1)math.his now deprecated for use in C++ code, 2) increasing numbers of special functions are becoming available only in thecmath(see for example these in C++17).