[ML] Add a dev-tools/ci.bat script to automate the Windows portion of the CI #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To facilitate migration from ML team CI to Infra CI we need to make the steps triggered by Jenkins as simple as possible. This change adds a ci script that can be used for Windows.
edsavage
approved these changes
Apr 3, 2018
Contributor
edsavage
left a comment
edsavage
left a comment
There was a problem hiding this comment.
Looks good Dave. Just a question regarding the copyright date.
dev-tools/ci.bat
Outdated
| rem | ||
| rem ELASTICSEARCH CONFIDENTIAL | ||
| rem | ||
| rem Copyright (c) 2017 Elasticsearch BV. All Rights Reserved. |
Contributor
There was a problem hiding this comment.
Should the date be bumped to 2018?
Author
|
The idea is that Infra CI would run this on a worker VM set up using a provisioning script very similar to the one used by release manager. The difference would be that the VMs would run in EC2 or GCP rather than locally in VirtualBox. |
droberts195
pushed a commit
that referenced
this pull request
Apr 5, 2018
… the CI (#31) To facilitate migration from ML team CI to Infra CI we need to make the steps triggered by Jenkins as simple as possible. This change adds a ci script that can be used for Windows.
droberts195
pushed a commit
that referenced
this pull request
Apr 23, 2018
… the CI (#31) To facilitate migration from ML team CI to Infra CI we need to make the steps triggered by Jenkins as simple as possible. This change adds a ci script that can be used for Windows.
droberts195
pushed a commit
that referenced
this pull request
Apr 23, 2018
… the CI (#31) To facilitate migration from ML team CI to Infra CI we need to make the steps triggered by Jenkins as simple as possible. This change adds a ci script that can be used for Windows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To facilitate migration from ML team CI to Infra CI we need to make the
steps triggered by Jenkins as simple as possible.
This change adds a ci script that can be used for Windows.
(#29 is the corresponding change for Linux/macOS.)