[ML] Include an extra header in CDataFrameRowSlice #2563
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our two ARM macOS build servers have somehow ended up running different versions of Xcode - one is running version 12 and the other version 13. There have been changes to the C++ standard library between these versions that reveal a technical violation that we were previously getting away with: CDataFrameRowSlice.cc uses file streams without including the necessary header. Previously it must have been indirectly included. This PR includes it explicitly.
droberts195
pushed a commit
to droberts195/ml-cpp
that referenced
this pull request
Sep 5, 2023
Our two ARM macOS build servers have somehow ended up running different versions of Xcode - one is running version 12 and the other version 13. There have been changes to the C++ standard library between these versions that reveal a technical violation that we were previously getting away with: CDataFrameRowSlice.cc uses file streams without including the necessary header. Previously it must have been indirectly included. This PR includes it explicitly. Backport of elastic#2563
droberts195
pushed a commit
to droberts195/ml-cpp
that referenced
this pull request
Sep 5, 2023
Our two ARM macOS build servers have somehow ended up running different versions of Xcode - one is running version 12 and the other version 13. There have been changes to the C++ standard library between these versions that reveal a technical violation that we were previously getting away with: CDataFrameRowSlice.cc uses file streams without including the necessary header. Previously it must have been indirectly included. This PR includes it explicitly. Backport of elastic#2563
droberts195
pushed a commit
that referenced
this pull request
Sep 5, 2023
Our two ARM macOS build servers have somehow ended up running different versions of Xcode - one is running version 12 and the other version 13. There have been changes to the C++ standard library between these versions that reveal a technical violation that we were previously getting away with: CDataFrameRowSlice.cc uses file streams without including the necessary header. Previously it must have been indirectly included. This PR includes it explicitly. Backport of #2563
droberts195
pushed a commit
that referenced
this pull request
Sep 5, 2023
Our two ARM macOS build servers have somehow ended up running different versions of Xcode - one is running version 12 and the other version 13. There have been changes to the C++ standard library between these versions that reveal a technical violation that we were previously getting away with: CDataFrameRowSlice.cc uses file streams without including the necessary header. Previously it must have been indirectly included. This PR includes it explicitly. Backport of #2563
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our two ARM macOS build servers have somehow ended up running different versions of Xcode - one is running version 12 and the other version 13.
There have been changes to the C++ standard library between these versions that reveal a technical violation that we were previously getting away with: CDataFrameRowSlice.cc uses file streams without including the necessary header. Previously it must have been indirectly included. This PR includes it explicitly.