[ML] How to profile autodetect on MacOS #2526
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tveasey
reviewed
Jun 15, 2023
Contributor
tveasey
left a comment
tveasey
left a comment
There was a problem hiding this comment.
Overall looks great. One top-level comment: do we need record_memgraph.sh and record_xctrace.sh? I wonder if we can just run both commands at once.
dev-tools/autodetect_profiling_macos/autodetect_profiling_on_macos.md
Outdated
Show resolved
Hide resolved
…acos.md Co-authored-by: Tom Veasey <[email protected]>
Contributor
Author
|
@tveasey IMO, we usually don't want to record more information than needed as it is resource-expensive. The scripts are useful examples. I wouldn't expect them to be comprehensive tools. For instance, using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds bash scripts and a description of how to profile the anomaly detection process started from the Elasticsearch Java backend.