[ML] Encapsulate timestamp conversion from epoch seconds to epoch millis #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
droberts195
reviewed
Mar 14, 2018
droberts195
left a comment
droberts195
left a comment
There was a problem hiding this comment.
Does CModelSnapshotJsonWriter.cc need updating too?
lib/core/unittest/CTimeUtilsTest.cc
Outdated
| CPPUNIT_ASSERT_EQUAL(ml::core::CTimeUtils::toEpochMs(ml::core_t::TTime(1)), int64_t(1000)); | ||
| CPPUNIT_ASSERT_EQUAL(ml::core::CTimeUtils::toEpochMs(ml::core_t::TTime(-1)), int64_t(-1000)); | ||
| CPPUNIT_ASSERT_EQUAL(ml::core::CTimeUtils::toEpochMs(ml::core_t::TTime(1521035866)), int64_t(1521035866000)); | ||
| CPPUNIT_ASSERT_EQUAL(ml::core::CTimeUtils::toEpochMs(ml::core_t::TTime(-1521035866)), int64_t(-1521035866000)); |
There was a problem hiding this comment.
The order of arguments should be (expected, actual).
Contributor
Author
There was a problem hiding this comment.
Yes. I was testing you :P
| { | ||
| int64_t javaTimestamp = int64_t(value) * 1000; | ||
| TValue v(javaTimestamp); | ||
| TValue v(CTimeUtils::toEpochMs(value)); |
There was a problem hiding this comment.
Lower down this file, around line 550-555 value * int64_t(1000) can also be changed.
Contributor
Author
|
Good catch. Addressed all points. |
dimitris-athanasiou
deleted the
encapsulate-timestamp-conversion-from-epoch-seconds-to-epoch-millis
branch
dimitris-athanasiou
added a commit
that referenced
this pull request
Mar 14, 2018
droberts195
pushed a commit
that referenced
this pull request
Apr 23, 2018
droberts195
pushed a commit
that referenced
this pull request
Apr 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.