[ML] build boost test framework in buildenv #157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
droberts195
reviewed
Jul 18, 2018
droberts195
left a comment
droberts195
left a comment
There was a problem hiding this comment.
There are also two instances of --without-test in build-setup/windows.md that need removing.
Author
|
👍 changed it locally but forgot to save/push it. done now. |
droberts195
pushed a commit
to droberts195/ml-cpp
that referenced
this pull request
Oct 18, 2018
Relates elastic#156 This change includes changes similar to those made in elastic#157, but for the 6.x branch, and also incorporates rebuilds of VM setup bundles and Docker image updates.
droberts195
pushed a commit
that referenced
this pull request
Oct 18, 2018
droberts195
pushed a commit
to droberts195/ml-cpp
that referenced
this pull request
Oct 18, 2018
Relates elastic#156 This is basically the other half of elastic#157. It does the things that were done for the 6.x branch in elastic#263 that weren't done in elastic#157. One extra point of confusion is that the macOS Docker image does not need updating in this PR because it was already rebuilt by elastic#225 using the updated instructions of elastic#157. So elastic#225 added Boost Test for macOS for the master branch.
droberts195
pushed a commit
that referenced
this pull request
Oct 19, 2018
Relates #156 This is basically the other half of #157. It does the things that were done for the 6.x branch in #263 that weren't done in #157. One extra point of confusion is that the macOS Docker image does not need updating in this PR because it was already rebuilt by #225 using the updated instructions of #157. So #225 added Boost Test for macOS for the master branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enable build of boost test framework in all provision steps and change documentation accordingly
Relates to #156