[7.10][ML] Adding a minimum disk space forecast parameter #1559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This new parameter will allow the value of the xpack.ml.min_disk_space_off_heap Elasticsearch setting to be propagated to the autodetect process. It will prevent problems where xpack.ml.min_disk_space_off_heap has been set to a low value but the previous hardcoded C++ check still prevented forecasting from working. Backport of elastic#1556
droberts195
pushed a commit
that referenced
this pull request
Dec 4, 2020
)" This reverts commit ce7c023.
droberts195
pushed a commit
to droberts195/ml-cpp
that referenced
this pull request
Dec 4, 2020
Due to a mistake in elastic#1559 the forecast bounds were reduced from 95% to 0.95%. This change reinstates the correct bounds, and also moves the definition of the constant to the maths library, where it can be used in a unit test that will fail if it is ever inadvertently changed again. Fixes elastic#1606
droberts195
pushed a commit
to droberts195/ml-cpp
that referenced
this pull request
Dec 7, 2020
Due to a mistake in elastic#1559 the forecast bounds were reduced from 95% to 0.95%. This change reinstates the correct bounds, and also moves the definition of the constant to the maths library, where it can be used in a unit test that will fail if it is ever inadvertently changed again. Backport of elastic#1610
droberts195
pushed a commit
that referenced
this pull request
Dec 7, 2020
Due to a mistake in #1559 the forecast bounds were reduced from 95% to 0.95%. This change reinstates the correct bounds, and also moves the definition of the constant to the maths library, where it can be used in a unit test that will fail if it is ever inadvertently changed again. Backport of #1610
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new parameter will allow the value of the
xpack.ml.min_disk_space_off_heap Elasticsearch setting
to be propagated to the autodetect process. It will
prevent problems where xpack.ml.min_disk_space_off_heap
has been set to a low value but the previous hardcoded
C++ check still prevented forecasting from working.
Backport of #1556