[ML] Allow unbounded num_top_classes in classification analysis #1526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
przemekwitek
force-pushed
the
allow_unbounded_num_top_classes
branch
from
56b5e7a to
c3c5e92
Compare
tveasey
reviewed
Oct 8, 2020
Contributor
tveasey
left a comment
tveasey
left a comment
There was a problem hiding this comment.
Functionally this looks fine but the signed unsigned comparison will generate a compiler warning with our settings so I think you should change the type of m_NumTopClasses.
przemekwitek
force-pushed
the
allow_unbounded_num_top_classes
branch
from
1aa20d1 to
398cb33
Compare
4 tasks
przemekwitek
added a commit
to przemekwitek/ml-cpp
that referenced
this pull request
Oct 12, 2020
przemekwitek
added a commit
to przemekwitek/ml-cpp
that referenced
this pull request
Oct 12, 2020
przemekwitek
added a commit
that referenced
this pull request
Oct 12, 2020
przemekwitek
added a commit
that referenced
this pull request
Oct 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the classification analysis accept
-1as the value ofnum_top_classesparameter. Whennum_top_classesis set to-1, all the predicted classes will be emitted in thetop_classesarray in the results.Relates elastic/elasticsearch#63306