[ML] Store feature importance baselines in model metadata #1522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
\ping @benwtrent |
benwtrent
added a commit
to elastic/elasticsearch
that referenced
this pull request
Oct 5, 2020
this adds the new field `feature_importance_baseline` and allows it to be optionally be included in the model's metadata. Related to: elastic/ml-cpp#1522
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
Oct 5, 2020
…ic#63172) this adds the new field `feature_importance_baseline` and allows it to be optionally be included in the model's metadata. Related to: elastic/ml-cpp#1522
Member
|
Java related PR: elastic/elasticsearch#63172 Verified formatting all works :) |
tveasey
approved these changes
Oct 5, 2020
Contributor
tveasey
left a comment
tveasey
left a comment
There was a problem hiding this comment.
This all looks good. I still feel we could unify binary and multiclass code paths by pushing some logic into CTreeShapFeatureImportance, but we can explore that in a separate change. I made a couple of purely cosmetic suggestions, which I'll address since I'm taking over getting this merged, but this is basically LGTM.
benwtrent
added a commit
to elastic/elasticsearch
that referenced
this pull request
Oct 5, 2020
… (#63237) this adds the new field `feature_importance_baseline` and allows it to be optionally be included in the model's metadata. Related to: elastic/ml-cpp#1522
tveasey
pushed a commit
to tveasey/ml-cpp-1
that referenced
this pull request
Oct 5, 2020
With this PR we will be able to store the feature importance baselines explicitly in the model_metadata. Being able baseline to retrieve the baselines will significantly simplify UI code related to the feature importance visualization.
Contributor
Author
|
Thank you for getting this PR merged @tveasey 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR we will be able to store the feature importance baselines explicitly in the
model_metadata. Being able baseline to retrieve the baselines will significantly simplify UI code related to the feature importance visualization.Classification
Regression
This is not a user-facing change, hence I mark it as a
non-issue.