[ML] Fixed errors identified by valgrind memcheck #1445
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Valgrind memcheck was run over the unit test suite. The tool picked up an error related to unit test code only and another in production code itself.
|
Please could you also backport this to 7.x? We should be backporting all minor fixes back to 7.x unless there's a really good reason not to. |
edsavage
added a commit
that referenced
this pull request
Aug 6, 2020
Valgrind memcheck was run over the unit test suite. The tool picked up an error related to unit test code only and another in production code itself. Backports #1445
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Valgrind'smemchecktool was run over the unit test suite. The tool picked upan error related to unit test code only and another in production code
itself. Labelling as a non-issue because of the relatively minor nature of the problems identified.