[ML] Fixing memory_status output on fatal error #1432
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valeriy42
changed the title
tveasey
reviewed
Jul 23, 2020
Contributor
tveasey
left a comment
tveasey
left a comment
There was a problem hiding this comment.
I had a couple of minor comments, but my major comment is that I don't see how making the results writer a member of CDataFrameAnalyzer helps the situation because this also has automatic storage in the context of data_frame_analyzer command.
Contributor
Author
|
@tveasey thank you for your review. At the end it turned out enough to have one additional |
tveasey
approved these changes
Jul 23, 2020
Contributor
tveasey
left a comment
tveasey
left a comment
There was a problem hiding this comment.
As discussed, we probably need to revisit cleanup on HANDLE_FATAL going forward, but this is the best fix for 7.9.
valeriy42
added a commit
to valeriy42/ml-cpp
that referenced
this pull request
Jul 24, 2020
When the job is failing due to the memory limit exceeding, the job fails to emit the final memory_status message. This PR fixes this. There was a type in the "hard_limit" tag which I fixed. Also I tweaked the parameters of the unit test CDataFrameAnalyzerTrainingTest.testMemoryLimitHandling to reduce runtime. Additionally I took the new messaging from elastic#1428 and added it here to avoid merge conflicts.
valeriy42
added a commit
to valeriy42/ml-cpp
that referenced
this pull request
Jul 24, 2020
When the job is failing due to the memory limit exceeding, the job fails to emit the final memory_status message. This PR fixes this. There was a type in the "hard_limit" tag which I fixed. Also I tweaked the parameters of the unit test CDataFrameAnalyzerTrainingTest.testMemoryLimitHandling to reduce runtime. Additionally I took the new messaging from elastic#1428 and added it here to avoid merge conflicts.
This was referenced Jul 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the job is failing due to the memory limit exceeding, the job fails to emit the final memory_status message. This PR fixes this.
There was a type in the "hard_limit" tag which I fixed. Also I tweaked the parameters of the unit test
CDataFrameAnalyzerTrainingTest.testMemoryLimitHandlingto reduce runtime.Additionally I took the new messaging from #1428 and added it here to avoid merge conflicts.