[ML] Upgrade gcc to version 7.5 #1013
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is primarily to upgrade the gcc we use from version 7.3 to version 7.5. A secondary change is to build a recent version of the binutils package from source for use in our builds instead of relying on whatever happened to come with the build machine. Both changes are driven by the desire to build Tensorflow in the future. gcc 7.3 suffers from an internal compiler error when trying to compile Tensorflow. The bug is fixed in gcc 7.5. Also, the assembler that comes with binutils 2.20 is too old to assemble the compiler output when building Tensorflow, and version 2.20 is what CentOS 6 ships with. Since our build platform for released product is CentOS 6 we also need to install a newer version of binutils.
droberts195
commented
Feb 19, 2020
| @@ -1,2 +1,2 @@ | |||
| name,version,revision,url,license,copyright | |||
| GCC Runtime Library,6.2.0,6ac74a62ba7258299cf85fbef9bf45333ddf10c0,https://gcc.gnu.org,GPL-3.0 WITH GCC-exception-3.1,"Copyright (C) 2016 Free Software Foundation, Inc." | |||
| GCC Runtime Library,7.5.0,b2d961e7342b5ba4e57adfa81cb189b738d10901,https://gcc.gnu.org,GPL-3.0 WITH GCC-exception-3.1,"Copyright (C) 2019 Free Software Foundation, Inc." | |||
Author
There was a problem hiding this comment.
If you are eagle-eyed you will notice that the old version was wrong here. I opened #1014 to fix that.
droberts195
pushed a commit
to droberts195/ml-cpp
that referenced
this pull request
Feb 19, 2020
This change is primarily to upgrade the gcc we use from version 7.3 to version 7.5. A secondary change is to build a recent version of the binutils package from source for use in our builds instead of relying on whatever happened to come with the build machine. Both changes are driven by the desire to build Tensorflow in the future. gcc 7.3 suffers from an internal compiler error when trying to compile Tensorflow. The bug is fixed in gcc 7.5. Also, the assembler that comes with binutils 2.20 is too old to assemble the compiler output when building Tensorflow, and version 2.20 is what CentOS 6 ships with. Since our build platform for released product is CentOS 6 we also need to install a newer version of binutils. Backport of elastic#1013
droberts195
pushed a commit
that referenced
this pull request
Feb 19, 2020
This change is primarily to upgrade the gcc we use from version 7.3 to version 7.5. A secondary change is to build a recent version of the binutils package from source for use in our builds instead of relying on whatever happened to come with the build machine. Both changes are driven by the desire to build Tensorflow in the future. gcc 7.3 suffers from an internal compiler error when trying to compile Tensorflow. The bug is fixed in gcc 7.5. Also, the assembler that comes with binutils 2.20 is too old to assemble the compiler output when building Tensorflow, and version 2.20 is what CentOS 6 ships with. Since our build platform for released product is CentOS 6 we also need to install a newer version of binutils. Backport of #1013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is primarily to upgrade the gcc we use from version 7.3
to version 7.5.
A secondary change is to build a recent version of the binutils
package from source for use in our builds instead of relying on
whatever happened to come with the build machine.
Both changes are driven by the desire to build Tensorflow in the
future. gcc 7.3 suffers from an internal compiler error when
trying to compile Tensorflow. The bug is fixed in gcc 7.5. Also,
the assembler that comes with binutils 2.20 is too old to assemble
the compiler output when building Tensorflow, and version 2.20 is
what CentOS 6 ships with. Since our build platform for released
product is CentOS 6 we also need to install a newer version of
binutils.