feat: add option to skip SSL verification #77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💚 CLA has been signed |
|
I signed the CLA now, should be good to go. |
|
buildkite test this |
slhck
force-pushed
the
add-skip-ssl-verify-option
branch
from
fb9f740 to
e5070c3
Compare
|
Sorry for introducing some whitespace changes. There are trailing spaces in the original code that my editor removed. Did a new push with only the relevant changes. |
slhck
force-pushed
the
add-skip-ssl-verify-option
branch
from
e5070c3 to
a50baf0
Compare
|
buildkite test this |
|
buildkite test this |
JoshMock
previously approved these changes
Jun 12, 2025
JoshMock
approved these changes
Jun 13, 2025
|
buildkite test this |
|
Thanks for the merge! Would it be possible to trigger a new release? |
|
@slhck A new release should go out sometime this week! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #65.
In local development, it should be possible to skip SSL verification altogether, because custom certificates don't always work on localhost domains.