Skip to content

Fix default user value #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 24, 2025
Merged

Fix default user value #106

merged 2 commits into from
Jun 24, 2025

Conversation

@atline
Copy link
Contributor

@atline atline commented Jun 24, 2025 •
edited
Loading

If there is no apikey specified, the mcp server will simply skip the username/password, which make MCP server can't connect to elasticsearch.

This is a regresstion by 35cc88e

In fact apiKey: process.env.ES_API_KEY ?? '' will become '', which make next code never send username, password to elasticsearch.

  if (apiKey != null) {
    clientOptions.auth = { apiKey }
  } else if (username != null && password != null) {
    clientOptions.auth = { username, password }
  }

With this patch, the undefined will match the else if, so bug fixed.

@cla-checker-service
Copy link

cla-checker-service bot commented Jun 24, 2025 •
edited
Loading

💚 CLA has been signed

@atline atline force-pushed the fix_default_value branch 2 times, most recently from 9ebd014 to 80f36cc Compare June 24, 2025 08:20
@atline
Fix default user value
2622ded 
If there is no apikey specified, the mcp server will simply
skip the username/password, which make MCP server can't connect
to elasticsearch.

This is a regresstion by elastic@35cc88e

Signed-off-by: Larry Shen <[email protected]>
@atline atline force-pushed the fix_default_value branch from 80f36cc to 2622ded Compare June 24, 2025 12:23
JoshMock
JoshMock approved these changes Jun 24, 2025
View reviewed changes
Copy link
Member

@JoshMock JoshMock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thanks for the contribution!

@JoshMock
Copy link
Member

buildkite test this

@JoshMock JoshMock merged commit 07073d3 into elastic:main Jun 24, 2025
2 checks passed
@JoshMock JoshMock mentioned this pull request Jun 24, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoshMock JoshMock JoshMock approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@atline @JoshMock