temp_directory can now be modified in conf file #1344
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
File.join should be used here to build paths. I know there are inconsistencies with this in the codebase.
Contributor
|
Thanks for your contribution - looks like a sound proposal! |
|
Can one of the admins verify this patch? |
jordansissel
force-pushed
the
master
branch
from
f86287d to
a536eef
Compare
Member
|
hi @whaley, since we're moving the plugins to separate repositories, would you mind reopening this PR in https://github.com/logstash-plugins/logstash-output-s3? Thanks! |
Contributor
There was a problem hiding this comment.
I think the default should be the system's temporary directory. Dir.tmpdir usually reports this.
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to https://logstash.jira.com/browse/LOGSTASH-155 .
There is another PR that supposedly fixes this at #938 , but contains much more than needed by this issue.