Skip to content

Conversation

@jsvd
Copy link
Member

@jsvd jsvd commented Oct 30, 2019

@jsvd
Copy link
Member Author

jsvd commented Nov 19, 2019

@colinsurprenant can you check here if we're good with removing the dns patch as you were quite involved in that (jruby/jruby#5722)?

@jsvd jsvd requested a review from colinsurprenant November 19, 2019 11:41
@colinsurprenant
Copy link
Contributor

@jsvd indeed, we can now remove that patch in code and the dns filter starting with 9.2.9.0. Will provide PRs for both.

Copy link
Contributor

@colinsurprenant colinsurprenant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@colinsurprenant
Copy link
Contributor

created #11330 to remove patch in core.

@colinsurprenant
Copy link
Contributor

Also created logstash-plugins/logstash-filter-dns#58 for the dns filter.

@elasticsearch-bot
Copy link

João Duarte merged this into the following branches!

Branch Commits
master 0924e97
7.x 6346d03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants