Add pipeline.id to log lines #11075
Add pipeline.id to log lines #11075
Conversation
robbavey
left a comment
robbavey
left a comment
There was a problem hiding this comment.
@andsel - this is awesome.
Tested locally, and this seems to work well for both ruby and java execution engines.
Ideally, I think I'd like to see an integration test, along the lines of the slowlog_spec to ensure that the pipeline.id is output with a minimal config (which could then potentially be extended when we come up with more use cases when we improve logging)
andsel
force-pushed
the
feature/add_pipeline_id_to_log_lines
branch
from
b8ca006 to
c9ff6fd
Compare
robbavey
left a comment
robbavey
left a comment
There was a problem hiding this comment.
Couple of config nitpicks, and on the name of the test.
| @ls.spawn_logstash("-w", "1" , "-e", config) | ||
| @ls.wait_for_logstash | ||
| sleep 2 until @ls.exited? | ||
| pipelinelog_file = "#{temp_dir}/logstash-slowlog-plain.log" |
There was a problem hiding this comment.
Actually the name is logstash-plain.log and checks the plain output file
| it "should write logs to a new dir" do | ||
| settings = { | ||
| "path.logs" => temp_dir, | ||
| "slowlog.threshold.warn" => "500ms" |
There was a problem hiding this comment.
slowlog.threshold.warn is unnecessary, as we are not testing the slowlog
| count => 4 | ||
| } | ||
| } | ||
| filter { |
There was a problem hiding this comment.
This sleep filter is unnecessary (unless you were planning on adding a test that filters are logging the pipeline name correctly)
| let(:temp_dir) { Stud::Temporary.directory("logstash-pipelinelog-test") } | ||
| let(:config) { @fixture.config("root") } | ||
|
|
||
| it "should write logs to a new dir" do |
There was a problem hiding this comment.
Test name should be more descriptive of the test.
andsel
force-pushed
the
feature/add_pipeline_id_to_log_lines
branch
from
c9ff6fd to
9269a89
Compare
andsel
force-pushed
the
feature/add_pipeline_id_to_log_lines
branch
from
3267456 to
cda592f
Compare
this is fairly recent - since 7.4 (added in elasticGH-11075) there's a risk plugins would assume ThreadContext to exist or collide the 'global' constant - usually best to import where the Java class actually gets used ...
this is fairly recent - since 7.4 (added in elasticGH-11075) there's a risk plugins would assume ThreadContext to exist or collide the 'global' constant - usually best to import where the Java class actually gets used ...
3 participants
Add tag fish with pipeline.id to log lines